Skip to content

Support PHP 8.3–8.4 and Symfony 7.3–8.0 #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
makasim merged 42 commits into from
Dec 21, 2025
Merged

Support PHP 8.3–8.4 and Symfony 7.3–8.0 #1397

makasim merged 42 commits into from
Dec 21, 2025

Conversation

@andrewmy
Copy link
Contributor

@andrewmy andrewmy commented Nov 29, 2025 •
edited
Loading

  • Add PHP 8.3 and 8.4 to CI
  • Add Symfony 7.3, 7.4, 8.0 to CI
  • Drop PHP 8.1 from CI, it's EOL on 31.12.2025 — still installable there btw
  • Drop EOL Symfony versions CI — 6.2, 6.3, 7.0
  • Drop Symfony 6.4 as requested
  • Bump doctrine/orm lowest to the maintained 2.20
  • Bump doctrine/persistence lowest to the maintained 3.4/4.1, drop EOL v2
  • Bump doctrine/dbal to 3.6.2 for consistent DSN parsing
  • Bump ratchet/pawl to ^0.4.3 for guzzle api consistency
  • Bump ratchet/rfc6455 to ^0.4 for api consistency
  • Bump actions/checkout to v6 just because
  • Move all composer installing in CI to ramsey/composer-install@v3, we were using caching with set-output, see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Not adding PHP 8.5 to CI until there is a new ext-gearman (2.1.5?) release.

Blocked until Doctrine releases ORM v3.6 https://github.com/doctrine/orm/releases/tag/3.6.0

@andrewmy andrewmy changed the title Support PHP 8.5 and Symfony 8 Support PHP 8.3–8.5 and Symfony 7.3–8.0 Nov 29, 2025
@andrewmy andrewmy changed the title Support PHP 8.3–8.5 and Symfony 7.3–8.0 Support PHP 8.3–8.4 and Symfony 7.3–8.0 Dec 1, 2025
@andrewmy andrewmy marked this pull request as ready for review December 20, 2025 18:46
@andrewmy
Copy link
Contributor Author

andrewmy commented Dec 20, 2025

Enqueue\SnsQs\Tests\Spec\SnsQsSendToTopicAndReceiveNoWaitFromQueueTest::test
Failed asserting that null is an instance of interface "Interop\Queue\Message".
/mqdev/vendor/queue-interop/queue-spec/src/SendToTopicAndReceiveNoWaitFromQueueSpec.php:50
/mqdev/pkg/test/RetryTrait.php:26

This appears to be a flaky test, giving me headache previously too.
Only failed now on PHP 7.3, Symfony 7.3

@makasim worth a merge? 😅

@makasim
Copy link
Member

makasim commented Dec 21, 2025

Thank you for your contribution. Can you please drop Symfony 6 support?

@andrewmy
Copy link
Contributor Author

andrewmy commented Dec 21, 2025

Symfony 6.4 is LTS until November 2026, are you sure about dropping it? 😅

https://symfony.com/releases/6.4

@makasim
Copy link
Member

makasim commented Dec 21, 2025

Yes, supporting the last two versions should be fine. The one who sticks with LTS is likely to sit on older enqueue versions, too.

@andrewmy
Copy link
Contributor Author

andrewmy commented Dec 21, 2025 •
edited
Loading

k :) done

  • one more CI change with composer install, hope you don't mind

@makasim makasim merged commit c7c7f1a into php-enqueue:master Dec 21, 2025
30 checks passed
@makasim
Copy link
Member

makasim commented Dec 21, 2025

Thank you for your contribution!

@makasim
Copy link
Member

makasim commented Dec 21, 2025

Released in 0.10.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewmy @makasim